Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try intake v2 again #24

Merged
merged 14 commits into from
Apr 11, 2024
Merged

Try intake v2 again #24

merged 14 commits into from
Apr 11, 2024

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Apr 2, 2024

Supersedes #22 didn't want to deal with the merge conflicts.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Apr 2, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: b92e005
✅ Deployment Preview URL: https://ProjectPythia.github.io/landsat-ml-cookbook/_preview/24

environment.yml Outdated Show resolved Hide resolved
@ahuang11 ahuang11 requested a review from droumis April 4, 2024 21:43
@ahuang11
Copy link
Collaborator Author

@droumis this is ready for review when you have some time; I moved it from the other branch because of the merge conflicts.

@droumis
Copy link
Member

droumis commented Apr 10, 2024

are you ok with me adding you to the list of authors?

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Apr 10, 2024

Yes absolutely; where is the author list?

@droumis
Copy link
Member

droumis commented Apr 11, 2024

Ok, I did a lot of cleanup and added a lot more contextual narrative framing to the intake notebook. Honestly, I would have much preferred if the intake notebook ends with showing the walker lake satellite image to match the other data ingestion notebook but I have no idea how to select a specific lonlat bbox with the intake approach. Also the last few cells of the intake notebook just lag indefinitely for me locally.. I'm pushing the work as is anyways to see if it runs and builds eventually on the CI. Hopefully my narrative framing makes sense..

I've also updated the toc and reframed the data ingestion options as either Geospatial specific or General purpose (intake), because the intake notebook now uses planetary computer as the source so it didn't make sense to call one of them the 'planetary computer approach' when they both use it. I hope that makes more sense and I hope someone (Martin?) can help improve the intake notebook in the future.

I also update the spectral clustering notebook to programmatically grab the lake water cluster since it was indeterministic before and ended up being wrong sometimes.

@ahuang11
Copy link
Collaborator Author

Also the last few cells of the intake notebook just lag indefinitely for me locally..

It seems to have worked on the website. I think it just takes a long time because it reads the entire stac catalog.

The rest makes sense to me! I'm happy to first merge it so at least it's in a working state, and in the future, it can be enhanced!

Thanks for cleaning it up!

@ahuang11
Copy link
Collaborator Author

ahuang11 commented Apr 11, 2024

(I can't approve it since it's my own PR, but feel free to merge when you're ready!)

@droumis
Copy link
Member

droumis commented Apr 11, 2024

ok, just pushed last commit.. will check the build once it's done then hopefully merge

@droumis droumis merged commit b47b454 into main Apr 11, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants