Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and validation improvements for fe_integration resource #30

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

mrmauer
Copy link
Collaborator

@mrmauer mrmauer commented Jan 9, 2025

Resolves issues mentioned here.

After PR

  1. We validate urls and url paths for the fe_integration resource
  2. We correctly parse responses when fetching fe_integration info for staging environments
  3. We check whether application url is localhost with http and set the application_url.type appropriately if so. We also perform the reverse when updating the state on Reads.
  4. We add unit tests to all utils, including those used for point 1 above.

@mrmauer mrmauer marked this pull request as ready for review January 10, 2025 18:28
@mrmauer mrmauer requested a review from a team as a code owner January 10, 2025 18:28
Copy link
Collaborator

@andrew-propelauth andrew-propelauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mrmauer mrmauer merged commit 8f0bf76 into main Jan 10, 2025
3 checks passed
@mrmauer mrmauer deleted the bug/1016 branch January 10, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants