fix(BRIDGE-10): escaping db path when creating connection

fix(BRIDGE-10): added tests

internal/db_impl/sqlite3/client.go

@@ -6,6 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"io/fs"
+	"net/url"
 	"os"
 	"path/filepath"
 	"sync"
@@ -287,7 +288,9 @@ func pathExists(path string) (bool, error) {
 }
 
 func getDatabaseConn(dir, userID, path string) string {
-	return fmt.Sprintf("file:%v?cache=shared&_fk=1&_journal=WAL", path)
+	// We need to escape special characters in the db path, such as #
+	escapedPath := url.PathEscape(path)
+	return fmt.Sprintf("file:%v?cache=shared&_fk=1&_journal=WAL", escapedPath)
 }
 
 func TestUpdateDBVersion(ctx context.Context, dbPath, userID string, version int) error {

internal/db_impl/sqlite3/client_test.go

@@ -0,0 +1,60 @@
+package sqlite3
+
+import (
+	"database/sql"
+	"fmt"
+	"os"
+	"os/user"
+	"path/filepath"
+	"testing"
+)
+
+const (
+	TestingDirectoryRoot = "/tmp/test_db_sqlite"
+)
+
+func TestClient_db_connection_special_characters_path(t *testing.T) {
+	dbDirs := []string{
+		"#test",
+		"test_test",
+		"test#test#test",
+		"test$test$test",
+	}
+
+	curUser, err := user.Current()
+	if err != nil {
+		fmt.Println("Could not get current current user, error: ", err)
+		t.FailNow()
+	}
+
+	testingDir := filepath.Join(curUser.HomeDir, TestingDirectoryRoot)
+
+	for _, dirName := range dbDirs {
+		path := filepath.Join(testingDir, dirName)
+		err = os.MkdirAll(path, 0777)
+		if err != nil {
+			fmt.Println("Could not create testing directory, error: ", err)
+			t.FailNow()
+		}
+
+		filePath := filepath.Join(path, "test.db")
+
+		client, err := sql.Open("sqlite3", getDatabaseConn("test", "test", filePath))
+		if err != nil {
+			fmt.Println("Could not connect to test database, error: ", err)
+			t.FailNow()
+		}
+
+		err = client.Ping()
+		if err != nil {
+			fmt.Println("Could not ping test database, error: ", err)
+			t.FailNow()
+		}
+	}
+
+	err = os.RemoveAll(TestingDirectoryRoot)
+	if err != nil {
+		fmt.Println("Could not remove testing directory, error: ", err)
+		t.FailNow()
+	}
+}