Fix isForwardingKey to support keys without valid encryption subkeys
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function used to mistakenly check only for the absence of valid encryption keys. This would work in practice as forwarding subkeys are not valid for encryption, and standard private address keys are expected to have valid encryption subkeys. However, it caused issues in a specific account setup where the user imported an expiring key, which was then wrongly considered to be a forwarding key, which prevented the user from generating a valid SKL as a result (the FE filtered out the key on SKL generation, while the BE expected the key to be included).
twiss
reviewed
Jan 27, 2025
twiss
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.