Skip to content

Commit

Permalink
Add metrics for uploaded and deleted s3 objects (seaweedfs#6475)
Browse files Browse the repository at this point in the history
  • Loading branch information
hadizamani021 authored Jan 26, 2025
1 parent be15fee commit a2330f6
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 1 deletion.
3 changes: 3 additions & 0 deletions weed/s3api/s3api_object_handlers_delete.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (

"github.com/seaweedfs/seaweedfs/weed/glog"
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
stats_collect "github.com/seaweedfs/seaweedfs/weed/stats"
"github.com/seaweedfs/seaweedfs/weed/util"
)

Expand Down Expand Up @@ -56,6 +57,7 @@ func (s3a *S3ApiServer) DeleteObjectHandler(w http.ResponseWriter, r *http.Reque
return
}

stats_collect.S3DeletedObjectsCounter.WithLabelValues(bucket).Inc()
w.WriteHeader(http.StatusNoContent)
}

Expand Down Expand Up @@ -174,6 +176,7 @@ func (s3a *S3ApiServer) DeleteMultipleObjectsHandler(w http.ResponseWriter, r *h
deleteResp.DeletedObjects = deletedObjects
}
deleteResp.Errors = deleteErrors
stats_collect.S3DeletedObjectsCounter.WithLabelValues(bucket).Add(float64(len(deletedObjects)))

writeSuccessResponseXML(w, r, deleteResp)

Expand Down
3 changes: 2 additions & 1 deletion weed/s3api/s3api_object_handlers_multipart.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
"github.com/seaweedfs/seaweedfs/weed/s3api/s3err"
weed_server "github.com/seaweedfs/seaweedfs/weed/server"

stats_collect "github.com/seaweedfs/seaweedfs/weed/stats"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/s3"
)
Expand Down Expand Up @@ -91,6 +91,7 @@ func (s3a *S3ApiServer) CompleteMultipartUploadHandler(w http.ResponseWriter, r
s3err.WriteErrorResponse(w, r, errCode)
return
}
stats_collect.S3UploadedObjectsCounter.WithLabelValues(bucket).Inc()

writeSuccessResponseXML(w, r, response)

Expand Down
1 change: 1 addition & 0 deletions weed/s3api/s3api_object_handlers_put.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ func (s3a *S3ApiServer) PutObjectHandler(w http.ResponseWriter, r *http.Request)

setEtag(w, etag)
}
stats_collect.S3UploadedObjectsCounter.WithLabelValues(bucket).Inc()

writeSuccessResponseEmpty(w, r)
}
Expand Down
18 changes: 18 additions & 0 deletions weed/stats/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,22 @@ var (
Name: "bucket_traffic_sent_bytes_total",
Help: "Total number of bytes sent from an S3 bucket to clients.",
}, []string{"bucket"})

S3DeletedObjectsCounter = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: Namespace,
Subsystem: "s3",
Name: "deleted_objects",
Help: "Number of objects deleted in each bucket.",
}, []string{"bucket"})

S3UploadedObjectsCounter = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: Namespace,
Subsystem: "s3",
Name: "uploaded_objects",
Help: "Number of objects uploaded in each bucket.",
}, []string{"bucket"})
)

func init() {
Expand Down Expand Up @@ -380,6 +396,8 @@ func init() {
Gather.MustRegister(S3TimeToFirstByteHistogram)
Gather.MustRegister(S3BucketTrafficReceivedBytesCounter)
Gather.MustRegister(S3BucketTrafficSentBytesCounter)
Gather.MustRegister(S3DeletedObjectsCounter)
Gather.MustRegister(S3UploadedObjectsCounter)

go bucketMetricTTLControl()
}
Expand Down

0 comments on commit a2330f6

Please sign in to comment.