-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deps] Run cargo update #2604
base: staging
Are you sure you want to change the base?
[Deps] Run cargo update #2604
Conversation
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
The |
Hmm, I can't reproduce the |
Signed-off-by: ljedrz <[email protected]>
It might be the nodeJS version? I see |
@niklaslong it's entirely possible - I attempted to reproduce the issue on 2 other systems with cutting-edge packages and was unable to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things
- The
console_error_panic_hook
seems to have been removed - why? - The wasm bindings aren't being found. It could have to do with the version updates you applied via Cargo update not being compatible with
Cargo
's version ofwasm-pack
. Change the install of wasm-pack tocurl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
and see if that helps.
It could also be related to circleci failing to carry the bindings from cache, the error is:
code: 'MODULE_NOT_FOUND', requireStack: [ '/tmp/.tmp4821I1/run.cjs' ]
This indicates a wasm binding is missing from the /tmp
folder, indicating it might just be getting deleted in some step. If changing the wasm-pack installation target doesn't work, re-run the CI with ssh and check if the wasm bindings are in the place they're expected to be. If they're not, it points to them getting deleted somehow in CI.
] | ||
|
||
[[package]] | ||
name = "console_error_panic_hook" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed? This lowers visibility into wasm panics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lockfile change, so it must have been caused indirectly by one of the updates; it seems that it's no longer used by wasm-bindgen-test
.
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
A pure lockfile bump; if no issues are detected, a counterpart PR will follow for snarkOS.