Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] Run cargo update #2604

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Jan 27, 2025

A pure lockfile bump; if no issues are detected, a counterpart PR will follow for snarkOS.

@ljedrz
Copy link
Collaborator Author

ljedrz commented Jan 27, 2025

The wasm feature is producing new warnings now; I special-cased them, but an alternative approach might be preferable.

@ljedrz
Copy link
Collaborator Author

ljedrz commented Jan 27, 2025

Hmm, I can't reproduce the wasm job failure locally; I'll try re-running it.

@niklaslong
Copy link
Collaborator

It might be the nodeJS version? I see 12.22.9~dfsg-1ubuntu3.6 in the output which is pretty old?

@ljedrz
Copy link
Collaborator Author

ljedrz commented Jan 28, 2025

@niklaslong it's entirely possible - I attempted to reproduce the issue on 2 other systems with cutting-edge packages and was unable to do so.

Copy link
Contributor

@iamalwaysuncomfortable iamalwaysuncomfortable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things

  1. The console_error_panic_hook seems to have been removed - why?
  2. The wasm bindings aren't being found. It could have to do with the version updates you applied via Cargo update not being compatible with Cargo's version of wasm-pack. Change the install of wasm-pack to curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh and see if that helps.

It could also be related to circleci failing to carry the bindings from cache, the error is:
code: 'MODULE_NOT_FOUND', requireStack: [ '/tmp/.tmp4821I1/run.cjs' ]

This indicates a wasm binding is missing from the /tmp folder, indicating it might just be getting deleted in some step. If changing the wasm-pack installation target doesn't work, re-run the CI with ssh and check if the wasm bindings are in the place they're expected to be. If they're not, it points to them getting deleted somehow in CI.

]

[[package]]
name = "console_error_panic_hook"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed? This lowers visibility into wasm panics.

Copy link
Collaborator Author

@ljedrz ljedrz Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lockfile change, so it must have been caused indirectly by one of the updates; it seems that it's no longer used by wasm-bindgen-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants