Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inspect message #59

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add inspect message #59

wants to merge 3 commits into from

Conversation

qti3e
Copy link
Contributor

@qti3e qti3e commented Aug 5, 2022

Add an inspect message method to the Dank canister.


// exception: wallet_call should actually accept large payload, but only if user has
// the fee to pay.
if method_name == "wallet_call" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do this only if message size is greater than our threshold? This way this block doesn't need to run every wallet call. Very minor and I'm cool with leaving it as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@jsonsivar
Copy link
Collaborator

But heads up the tests CI check is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants