Avoid calls to ast in plugins #918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one day we do wish to have the capability to swap the builtin Python ast for another parser, it's best to abstract any direct calls to the ast parser in plugins. This change addresses calls from plugins and other functions to isinstance with ast node types as arguments. Further work is needed for other ast calls in subsequent patches. Related to #894 Signed-off-by: Eric Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one day we do wish to have the capability to swap the builtin
Python ast for another parser, it's best to abstract any direct
calls to the ast parser in plugins.
This change addresses calls from plugins and other functions to
isinstance with ast node types as arguments. Further work is needed
for other ast calls in subsequent patches.
Related to #894
Signed-off-by: Eric Brown [email protected]