Check path for hassyspath and use shutil.rmdir if True
#429
Conversation
| self.removedir(_path) | ||
| else: | ||
| self.remove(_path) | ||
| if _dir_path != "/": |
There was a problem hiding this comment.
I think you also need to check that _dir_path is not "/" with the shutil.rmtree branch too, otherwise you may end up deleting the root of the filesystem and potentially preventing new files/directories from being created in that filesystem afterwards.
| if _dir_path != "/": | ||
| self.removedir(dir_path) | ||
| if self.hassyspath(path): | ||
| shutil.rmtree(self.getsyspath(path)) |
There was a problem hiding this comment.
shutil.rmtree can potentially raise OSError, we would want to wrap it using the onerror callback, probably turning it into an fs.errors.OperationFailed.
|
I think this is a good optimization, but we just need a few tests to make sure it is consistent with the current By the way, |
Type of changes
Checklist
Description
Minor enhancement to
removetreewhen the path has a syspath and so can be removed viashutil.rmtree