Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all self-move operations raise IllegalDestination error #549

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Make all self-move operations raise IllegalDestination error #549

wants to merge 5 commits into from

Conversation

althonos
Copy link
Member

Type of changes

  • Bug fix
  • New feature
  • Tests

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added updated tests for new code.
  • I accept that @PyFilesystem/maintainers may be pedantic in the code review.

Description

As discussed with @lurch in #547, this PR makes all self-move operations raise IllegalDestination instead of being silent. In fs.move.move_file, DestinationExists takes priority if overwrite is False.

@althonos althonos added the bug label Aug 19, 2022
@althonos althonos requested a review from lurch August 19, 2022 13:24
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 94.811% when pulling ef508c2 on illegal-self-move into 59f6e4d on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch Awaiting requested review from lurch

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@althonos @coveralls