Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seq widgets #123

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix seq widgets #123

wants to merge 6 commits into from

Conversation

krysros
Copy link

@krysros krysros commented Jun 12, 2022

This pull request should fix functional tests of Pylons/deform#518.

@stevepiercy
Copy link
Member

@krysros I started the run, and so far lint failed, but it's not clear to me why. Perhaps you can make sense of it?

https://github.com/Pylons/deformdemo/runs/6872633267?check_suite_focus=true

We'll see about the other builds. At this point, I am OK with dropping Python 3.6 and adding 3.10, too.

@krysros
Copy link
Author

krysros commented Jun 16, 2022

@stevepiercy

I have no idea about lint fail yet. I passed all functional tests running locally from deform with the changes applied in Pylons/deform#523, Pylons/deform#524, #123 and with the following modifications of https://github.com/Pylons/deform/blob/1a6e9e07a9a7fa0208c1aa219649d99ebc132eb7/run-selenium-tests.bash#L31

git clone --branch fix-seq-widgets https://github.com/krysros/deformdemo.git deformdemo_functional_tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants