-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] bootstrap5 + icons #124
Conversation
We should also remove support for python < 3.10!? |
Here a preview (will turn it off at some point) http://168.119.117.235:8523/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. After I release deform 3.0.0a0, we will need to come back to this and bump that requirement. Thank you!
This is awesome work. Thank you so much for your effort. Pylons Project projects try to support currently supported versions of Python when the project is released. Right now Python 3.8-3.12 are supported. Would you please do two housekeeping tasks before I merge?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python version support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a more thorough review on this pass. A couple of minor changes, and I think it's good to go. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll merge this and then run CI in deform.
Changes to work with bootstrap5 and bootstrap icons