Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some extra info:
@inbounds
macro::Int32
constraints to make sure everything is actually an int32always_inline = true
for CUDA kernel callsThese changes might improve performance, but I haven't benchmarked it properly yet.
I also made the function generic so it can be used with any type
T
that supports basic arithmetic. To reflect that, I made the tests generic, too, and now test over some Float, Integer, and Complex types.Checklist