Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make main function generic #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented Jan 30, 2025

I added some extra info:

  • reasonable type information to function headers
  • @inbounds macro
  • some more ::Int32 constraints to make sure everything is actually an int32
  • always_inline = true for CUDA kernel calls
    These changes might improve performance, but I haven't benchmarked it properly yet.

I also made the function generic so it can be used with any type T that supports basic arithmetic. To reflect that, I made the tests generic, too, and now test over some Float, Integer, and Complex types.

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@AntonReinhard
Copy link
Member Author

I have made my own plots in this branch: https://github.com/AntonReinhard/InclusiveScans.jl/tree/plotting

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for providing this! I tested the code in a GV100, and it works. Therefore, I use my admin power to merge this.

Later we might configure GPU tests for this, but for now, this should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants