Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed ConstructionBase from dependency #81

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

szabo137
Copy link
Member

During the registration, auto-merge is blocked due to compatibility problems with ConstructionBase. See JuliaRegistries/General#109685 for details.

This hotfix removes ConstructionBase from the dependencies. It shall go directly to main, and will be backported to dev afterwards.

@szabo137 szabo137 requested a review from AntonReinhard June 24, 2024 20:26
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't ConstructionBase just generally be removed from this repository? The usage is now only in QEDcore, no?

@szabo137
Copy link
Member Author

szabo137 commented Jun 25, 2024

Can't ConstructionBase just generally be removed from this repository? The usage is now only in QEDcore, no?

This is what this PR does 🤷‍♂️
Or did I forgot something?

@szabo137 szabo137 merged commit a4fcee5 into main Jun 25, 2024
3 checks passed
@szabo137 szabo137 added this to the Release-0.2.0 milestone Jun 25, 2024
szabo137 added a commit that referenced this pull request Jun 25, 2024
During the registration, auto-merge is blocked due to compatibility
problems with `ConstructionBase`. See
JuliaRegistries/General#109685 for details.

This hotfix removes `ConstructionBase` from the dependencies. It shall
go directly to main, and will be backported to dev afterwards.

Co-authored-by: Uwe Hernandez Acosta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants