Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length to string encoding #191

Closed
wants to merge 2 commits into from

Conversation

osopardo1
Copy link
Member

Description

WIP on #188

Type of change

WIP

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fix has been committed following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

How Has This Been Tested? (Optional)

Please describe the tests that you ran to verify your changes.

  • Test A: (e.g., I have created the class FooTest.scala...)
  • Test B: (e.g., Running some benchmarks...)

Test Configuration:

  • Spark Version:
  • Hadoop Version:
  • Cluster or local?

osopardo1 added 2 commits May 5, 2023 14:58
This code is introducing a new transformation that encodes the string withing a specific length

But it does not maintain the lexicographic order, I am trying to understand why
@osopardo1 osopardo1 changed the title 188 length enconding Add length to string encoding May 12, 2023
@osopardo1
Copy link
Member Author

osopardo1 commented May 12, 2023

This is a Draft Pull Request with some structural changes for fixing #188

We incorporate a new Transformation called LengthHashTransformation (feel free to change the name, it was an ugly workaround 😄 ) which will encode the string with a pre-defined length, trying to ensure lexicographic order (very loosely) for hash.

We opened this mainly for @Adricu8 to take over the issue 👏
Good luck!! Let me know if you find any weird behaviour or code block.

@osopardo1
Copy link
Member Author

Closing this PR until clear planning.

@osopardo1 osopardo1 closed this Jun 9, 2023
@osopardo1 osopardo1 deleted the 188-length-enconding branch August 2, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant