Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#228 Implementation of equals/hashCode of CubeId is fixed #231

Conversation

alexeiakimov
Copy link
Contributor

Description

This PR fixes the implementation of equals/hashCode of the class CubeId and closes #228.

Type of change

This is a fix of internal implementation, so neither public API, nor serialization format are affected.

How Has This Been Tested? (Optional)

The corner cases mentioned in the bug #228 are added to the CubeIdTest class.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f066acf) 92.00% compared to head (65f5cb8) 91.98%.

❗ Current head 65f5cb8 differs from pull request most recent head 882a7f1. Consider uploading reports for the commit 882a7f1 to get more accurate results

Files Patch % Lines
...e/src/main/scala/io/qbeast/core/model/CubeId.scala 94.73% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           main-1.0.0     #231      +/-   ##
==============================================
- Coverage       92.00%   91.98%   -0.02%     
==============================================
  Files              88       88              
  Lines            2214     2209       -5     
  Branches          168      164       -4     
==============================================
- Hits             2037     2032       -5     
  Misses            177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cugni cugni merged commit cdcc4e2 into Qbeast-io:main-1.0.0 Nov 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants