Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #12977 #13679

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixes issue #12977 #13679

wants to merge 1 commit into from

Conversation

Ak-ash22
Copy link
Contributor

Summary

Updates the synthesis methods to use the PhaseGate instead of the IBM-legacy U1Gate.

Details and comments

Substituted the CU1/MCU1Gate for the CPhase/MCPhaseGate in the qiskit/synthesis/multi_controlled/mcx_synthesis.py file.

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jan 17, 2025
@Cryoris
Copy link
Contributor

Cryoris commented Jan 17, 2025

Thanks for opening the draft 🙂 The tests are failing because they were expecting the u1 gates (or cu1/mcu1) and now the phase gates are used. You can just update those tests to now expect the phase gates.

Could you include a releasenote which mentions this gate change for certain MCX gates under the upgrades section?

@Cryoris Cryoris added the Changelog: API Change Include in the "Changed" section of the changelog label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: API Change Include in the "Changed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants