Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errant print statements from tests (backport #13702) #13707

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 21, 2025

If any print is necessary for debugging failed test cases, we probably ought to reconfigure the test runner's display mechanisms, or use the built-in configuration of the unittest assert methods to produce better results.

Summary

Details and comments


This is an automatic backport of pull request #13702 done by [Mergify](https://mergify.com).

If any `print` is necessary for debugging failed test cases, we probably
ought to reconfigure the test runner's display mechanisms, or use the
built-in configuration of the `unittest` assert methods to produce
better results.

(cherry picked from commit d884a3c)
@mergify mergify bot requested a review from a team as a code owner January 21, 2025 15:17
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jan 21, 2025
@ElePT ElePT enabled auto-merge January 21, 2025 15:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12890041282

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 88.935%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 93.21%
crates/qasm2/src/lex.rs 3 92.48%
Totals Coverage Status
Change from base Build 12866145218: 0.01%
Covered Lines: 79192
Relevant Lines: 89045

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jan 21, 2025
Merged via the queue into stable/1.3 with commit 3e21326 Jan 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants