Allow Debugger.Break() on failing Result.Act()'s when the debugger is attachted #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjaaky
reviewed
Apr 5, 2023
| DebuggerWrapper.GetProperty(nameof(IsAttached)).SetValue(null, action); | ||
| } | ||
|
|
||
| public static void Break(bool @throw) |
There was a problem hiding this comment.
So a Break(true) throws an exception. And a Break(false) does a debugger.Break.
That's confusing.
There was a problem hiding this comment.
@Sjaaky I see your point. Do you have a suggestion? throwOnBreak? Or injection the action? Or somehting else?
|
My personal preference would still be to continue with #64 due to the less impactful change in experience. I can foresee scenarios where too many break points get triggered that hamper the development experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #64 , triggering
Debugger.Break()could also be a promising way to improve the debugger experience when dealing with longer chains of Result.Act()'s.