-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLOG] Add libsf_error_state: SciPy's first shared library #892
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write-up Albert! I like the structure of the story.
Thanks @rgommers for all of the suggestions. Me not understanding why the inplace build works but not |
@steppi I fixed the RPATH handling description - please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rgommers. I think I get it now. I left some suggestions which I hope did not change the meaning, trying to rewrite things using my own voice. Let me know if these look good.
Co-authored-by: Albert Steppi <[email protected]>
Thanks @steppi, those rewrites all looked good, so I merged them. Can you check the preview and see if you're happy with everything? |
Thanks Ralf. I made a last minute fix to move a closing parenthesis to the correct position and updated the date of the post. It all looks good to me now. |
Ha. Thanks Ralf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's declare victory here:) Very nice post, thanks Albert!
@rgommers, is there anything I need to do to get this deployed on |
Argh - yes indeed, this changed recently and I believe the instructions are outdated. Can you open a new PR to sync the changes to |
Sorry for accidentally targeting
main
with my first PR. Copied from before:This is nearly done so I figured it was time to make a PR here. Irwin Zaid, who was involved in the work described has read this draft and given a thumbs up (after making a couple small suggestions).
I still need to add footnotes and write the conclusion section at the end, which currently has section header ##Reflections. It looks like I'll also need to go through and confirm the text styling bullet points.
Text styling
Non-text contents