Avoid thread join without timeout

QuantConnect · May 9, 2024 · 7dc7525 · 7dc7525
1 parent dd264cf
commit 7dc7525
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/QuantConnect.InteractiveBrokersBrokerage/InteractiveBrokersBrokerage.cs b/QuantConnect.InteractiveBrokersBrokerage/InteractiveBrokersBrokerage.cs
@@ -1125,6 +1125,7 @@ private bool DownloadAccount()
         /// </summary>
         public override void Disconnect()
         {
+            Log.Trace("InteractiveBrokersBrokerage.Disconnect(): Starting");
             try
             {
                 if (_client != null && _client.ClientSocket != null && _client.Connected)
@@ -1142,9 +1143,13 @@ public override void Disconnect()
             if (_messageProcessingThread != null)
             {
                 _signal.issueSignal();
-                _messageProcessingThread.Join();
+                if (!_messageProcessingThread.Join(TimeSpan.FromSeconds(30)))
+                {
+                    Log.Error("InteractiveBrokersBrokerage.Disconnect(): timeout waiting for message processing thread to end");
+                }
                 _messageProcessingThread = null;
             }
+            Log.Trace("InteractiveBrokersBrokerage.Disconnect(): ended");
         }
 
         /// <summary>