Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1/9/2025 holiday to market-hours #8508

Conversation

JosueNina
Copy link
Contributor

@JosueNina JosueNina commented Jan 7, 2025

Description

Added 1/9/2025 holiday to MarketHours to observe the passing of President Jimmy Carter.

Related Issue

Motivation and Context

To account for the holiday on 1/9/2025 in market-hours-database.json

Requires Documentation Change

No.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@JosueNina JosueNina changed the title WIP: Add 1/9/2025 holiday to market-hours Add 1/9/2025 holiday to market-hours Jan 7, 2025
@Martin-Molinero Martin-Molinero force-pushed the feature-add-9-january-2025-holiday branch from 0f623bd to 7256547 Compare January 8, 2025 02:22
@Martin-Molinero Martin-Molinero merged commit 96410b5 into QuantConnect:master Jan 8, 2025
6 of 7 checks passed
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants