Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multiple market closes in date #8509

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Jan 8, 2025

Description

  • Fixes related to support assets with multiple daily market closes.
    Adding unit and regression tests
  • Minor regression test data count increase due to some missing FF OI bars in master using extended market hours

Related Issue

Closes #6475

Motivation and Context

See #8497

Requires Documentation Change

N/A

How Has This Been Tested?

New and existing tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero force-pushed the bug-6475-endofday-multiple-closes branch from eef1a02 to 1ab39b0 Compare January 8, 2025 21:59
- Fixes related to support assets with multiple daily market closes.
  Adding unit and regression tests
@Martin-Molinero Martin-Molinero force-pushed the bug-6475-endofday-multiple-closes branch from 1ab39b0 to 640f7b6 Compare January 9, 2025 14:05
@Martin-Molinero Martin-Molinero merged commit 0b1b72e into QuantConnect:master Jan 9, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong EndOfDay Event Time for Market.HKFE
1 participant