Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secondsTimeStep in selected unit tests #8528

Conversation

JosueNina
Copy link
Contributor

Description

Updated secondsTimeStep value in selected unit tests to address occasional test failures in GitHub CI

Related Issue

Closes #8492

Motivation and Context

Some unit tests intermittently fail in CI due to timing-related issues with secondsTimeStep.

Requires Documentation Change

No.

How Has This Been Tested?

The unit tests were executed locally to verify the changes, and the tests now pass consistently without failures.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@JosueNina JosueNina force-pushed the bug-8492-unit-test-failing-randomly branch from 40ebefd to 17e3100 Compare January 14, 2025 16:45
@JosueNina JosueNina force-pushed the bug-8492-unit-test-failing-randomly branch from 17e3100 to 0d84d29 Compare January 14, 2025 16:55
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Martin-Molinero Martin-Molinero merged commit 5accfd6 into QuantConnect:master Jan 14, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review unit tests failing randomly
2 participants