Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mhdb to add holidays for osaka exchange #8533

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

ashutoshrana171
Copy link
Contributor

Description

Adding holiday calendar for osaka exchange as part of support inclusion for nikkei 225 index

Motivation and Context

We are including support for nikkei 225 index. As part of this support we needed to update the mhdb file to include holiday calendar for osaka exchange (Japan Exchange Group)
Reference:

  1. JPX calendar
  2. market clock -> for historical calendar (confirmed dates by checking them one by one to confirm the exchange holiday)

Requires Documentation Change

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@Martin-Molinero Martin-Molinero merged commit 1cb8fcf into QuantConnect:master Jan 15, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants