(Array API support): Add __array_namespace_info__ and device
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagoel4512
force-pushed
the
add-namespace-info
branch
from
0f7e5a5 to
d6e841e
Compare
cbourjau
requested changes
Jan 28, 2025
ndonnx/_info.py
Outdated
Comment on lines
63
to
65
| # We don't support complex numbers yet due to immaturity in the ONNX ecoystem, so "complex floating" is meaningless. | ||
| # The Array API standard requires this key to be present so we set it to None. | ||
| "complex floating": None, |
There was a problem hiding this comment.
Returning something wrong is still not compliant with the standard, but it might lead to issues that are harder to debug than what one would get if the key were just missing. I think we should rather not return "complex floating" as a key.
There was a problem hiding this comment.
I do agree however the tests as they stand explicitly assert all the keys are present. See data-apis/array-api-tests#337.
adityagoel4512
force-pushed
the
add-namespace-info
branch
from
642c7a4 to
5f91aed
Compare
cbourjau
approved these changes
Jan 31, 2025
ndonnx/_info.py
Outdated
| ndx.uint64, | ||
| ] | ||
|
|
||
| def capabilities(self) -> dict: |
There was a problem hiding this comment.
Suggested change
| def capabilities(self) -> dict: | |
| def capabilities(self) -> dict[str, bool]: |
adityagoel4512
force-pushed
the
add-namespace-info
branch
from
7b7f930 to
4f6570c
Compare
adityagoel4512
added a commit
that referenced
this pull request
Jan 31, 2025
Co-authored-by: Christian Bourjau <[email protected]>
adityagoel4512
added a commit
that referenced
this pull request
Jan 31, 2025
Co-authored-by: Christian Bourjau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues with #6.