Manual improvements #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Account requirement from Transactions API. Bump to dotnet 6. Bump version.
PJvGrol
reviewed
May 8, 2023
| @@ -419,9 +419,6 @@ public System.Threading.Tasks.Task<Response4> TransactionsGetAsync(int? limit, s | |||
| /// <exception cref="ApiException">A server side error occurred.</exception> | |||
| public async System.Threading.Tasks.Task<Response4> TransactionsGetAsync(int? limit, string next, string note_prefix, TxType? tx_type, SigType? sig_type, string txid, ulong? round, ulong? min_round, ulong? max_round, int? asset_id, System.DateTimeOffset? before_time, System.DateTimeOffset? after_time, ulong? currency_greater_than, ulong? currency_less_than, string account_id, bool? rekey_to, System.Threading.CancellationToken cancellationToken) | |||
| { | |||
| if (account_id == null) | |||
There was a problem hiding this comment.
this API is to fetch transactions not just for accounts
Remove Creator from AssetHolding
Update AssetParams total to be BigInteger
- Removed unused namespaces (`System.Numerics`, `System.Threading`, `Algorand.V2.Algod.Model`) from `Transaction.cs` to clean up the codebase. - Changed `assetTotal` type from `BigInteger?` to `ulong?` in `Transaction` constructor, `CreateAssetCreateTransaction` method, `AssetParams` constructor, and `Total` property in `Model.cs`. This standardizes asset total representation and optimizes memory usage. - Ensured API consistency by applying the `assetTotal` type change across relevant methods and properties, facilitating easier use and understanding of the API. - Improved JSON serialization compatibility for asset totals by using `ulong?`, simplifying data interchange with other systems and services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.