Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpsoe block #488

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

transpsoe block #488

wants to merge 2 commits into from

Conversation

Roger-luo
Copy link
Member

here is an example of how to implement transpose block, I haven't impl any tests here, so this is only for reference.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (293be9a) to head (5d95278).
Report is 191 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   89.05%   88.51%   -0.55%     
==========================================
  Files          83       32      -51     
  Lines        4834     1741    -3093     
==========================================
- Hits         4305     1541    -2764     
+ Misses        529      200     -329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, however, tests are missing.


julia> YaoBlocks.mat(x::QFT) = mat(circuit(x));

julia> QFT(2)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example should be fixed.

@GiggleLiu
Copy link
Member

Oops, this PR is not for review. Then no worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants