Skip to content

Commit

Permalink
Proper debugging should yield passing CI
Browse files Browse the repository at this point in the history
  • Loading branch information
QueenOfSquiggles committed Nov 26, 2023
1 parent 437000d commit e90ea7e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/camera.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ impl IMarker3D for VirtualCamera3D {
if let Some(mut tree) = self.base.get_tree() {
if self.push_on_ready {
if let Some(brain_tree) = tree.get_first_node_in_group(CAMERA_BRAIN_GROUP.into()) {
let option_temp: Option<Gd<CameraBrain3D>> = brain_tree.try_cast();
if let Some(mut brain) = option_temp {
let option_temp: Result<Gd<CameraBrain3D>, Gd<Node>> = brain_tree.try_cast();
if let Some(mut brain) = option_temp.ok() {

Check failure on line 101 in src/camera.rs

View workflow job for this annotation

GitHub Actions / Clippy

matching on `Some` with `ok()` is redundant
let self_gd: Gd<Self> = self.base.clone().cast();
brain.bind_mut().push_cam(self_gd);
}
Expand Down
4 changes: 2 additions & 2 deletions src/interaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ impl InteractRaycast3D {
impl IRayCast3D for InteractRaycast3D {
fn physics_process(&mut self, _delta: f64) {
if let Some(collider) = self.base.get_collider() {
let option_typed: Option<Gd<Node3D>> = collider.try_cast();
if let Some(mut coll3d) = option_typed {
let option_typed: Result<Gd<Node3D>, Gd<Object>> = collider.try_cast();
if let Some(mut coll3d) = option_typed.ok() {

Check failure on line 76 in src/interaction.rs

View workflow job for this annotation

GitHub Actions / Clippy

matching on `Some` with `ok()` is redundant
let mut in_group = self.filter_groups.is_empty();
for g in self.filter_groups.as_slice() {
if coll3d.is_in_group(StringName::from(g)) {
Expand Down

0 comments on commit e90ea7e

Please sign in to comment.