Improve script installation/update change log handling

Questionable-Content-Extensions · Oct 3, 2018 · 01acc21 · 01acc21
1 parent 7bc6758
commit 01acc21
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 3 deletions.
diff --git a/assets/js/qc-ext-qcChangeLogDirective.js b/assets/js/qc-ext-qcChangeLogDirective.js
@@ -55,7 +55,6 @@ var qcExt;
 							} else {
 								return;
 							}
-							$('#changeLogDialog').modal('show');
 							self.versionUpdated = true;
 						});
 

diff --git a/assets/js/qc-ext-qcExtraDirective.js b/assets/js/qc-ext-qcExtraDirective.js
@@ -185,6 +185,17 @@ var qcExt;
 						comicService.comic > constants.taglineThreshold) {
 						self.missingDataInfo.push('a tagline');
 					}
+
+					if (qcExt.settings.version === undefined) {
+						// Version is undefined. We're a new user!
+						$log.debug('qcExtra(): Version undefined!');
+						self.showWelcomeMessage = true;
+					} else if (qcExt.settings.version !==
+						self.currentVersion) {
+						// Version is changed. Script has been updated!
+						$log.debug('qcExtra(): Version different!');
+						self.showUpdateMessage = true;
+					}
 				});
 			});
 
@@ -239,6 +250,11 @@ var qcExt;
 			$log.debug(item);
 		};
 
+		this.showChangeLog = function() {
+			self.showWelcomeMessage = false;
+			self.showUpdateMessage = false;
+			$('#changeLogDialog').modal('show');
+		};
 	}
 
 	qcExt.app.directive('qcExtra', function() {

diff --git a/assets/sass/style.scss b/assets/sass/style.scss
@@ -59,7 +59,15 @@ $link-color: #2ba6cb;
         margin-top: 10px;
 
         &.first-header {
-            margin-top: 0px;
+            margin-top: 0;
+        }
+
+        &.update-header {
+			margin-top: 0;
+			margin-bottom: 0;
+
+			color: #e43;
+			font-weight: bold;
         }
 
         small {

diff --git a/assets/templates/changeLog.html b/assets/templates/changeLog.html
@@ -28,10 +28,12 @@ <h4>Script updated!</h4>
                 <div ng-if="!clvm.previousVersion">
                     <h4>Script installed!</h4>
                     <p>Thank you for installing Questionable Content Extensions!</p>
-                </div>
+				</div>
+
                 <h4>NextVersion <small>NextDate</small></h4>
                 <ul>
                     <li>Use Angular's date formatting for a better user experience</li>
+                    <li>Don't throw change log in user's face on update or fresh installation, instead show small notice</li>
                 </ul>
 
                 <h4>0.5.1 <small>April 8, 2017</small></h4>

diff --git a/assets/templates/extra.html b/assets/templates/extra.html
@@ -31,6 +31,18 @@
         <tr ng-repeat="message in e.messages">
             <td>{{ message }}</td>
         </tr>
+        <tr ng-if="e.showWelcomeMessage">
+			<td>
+				<h1 class="update-header">Welcome to QC&nbsp;Extensions!</h1>
+				<a class="qc" ng-click="e.showChangeLog()">See change log!</a>
+			</td>
+        </tr>
+        <tr ng-if="e.showUpdateMessage">
+			<td>
+				<h1 class="update-header">QC Extensions updated!</h1>
+				<a class="qc" ng-click="e.showChangeLog()">See what's new!</a>
+			</td>
+        </tr>
         <tr ng-if="e.settings.editMode && e.editorData.missing.any">
             <td>
                 <h1 class="first-header">Comics with missing items</h1>
-Original file line number
+Diff line change
@@ Expand Up / @@ -55,7 +55,6 @@ var qcExt; @@
     							} else {
     								return;
     							}
-    							$('#changeLogDialog').modal('show');
     							self.versionUpdated = true;
     						});
@@ Expand Down @@