Skip to content

Commit

Permalink
Merge pull request #39 from trlkly/patch-3
Browse files Browse the repository at this point in the history
Fixes #37 (missing sidebar on direct comic pages)
  • Loading branch information
ilyvion authored Dec 8, 2019
2 parents b0977fb + 2c8b30b commit d8fe68f
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
4 changes: 4 additions & 0 deletions assets/js/modules/dom-modifier.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@ export default class DomModifier {

$('#news, #newspost').replaceWith('<qc-news></qc-news>');

if (comicDirective.parent().siblings('.small-2').length === 0) {
// There's no column after the comic: Insert our own
comicDirective.parent().after('<div class="small-2 medium-expand column"></div>');
}
comicDirective.parent().siblings('.small-2').prepend('<qc-extra></qc-extra>');

// Set a base (required by Angular's html5Mode)
Expand Down
5 changes: 4 additions & 1 deletion assets/templates/changeLog.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ <h4>NextVersion <small>NextDate</small></h4>
<li></li>
</ul>
-->

<h4>0.6.1 <small>December 8, 2019</small></h4>
<ul>
<li>Fix missing sidebar when loading a comic directly by number in URL.</li>
</ul>
<h4>0.6.0 <small>March 7, 2019</small></h4>
<div class="change-log-entry">
<p class="developer-message">
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "questionable-content-spa",
"version": "0.6.0",
"version": "0.6.1",
"description": "Questionable Content Single-Page Application with Extra Features",
"main": "app.js",
"scripts": {
Expand Down

0 comments on commit d8fe68f

Please sign in to comment.