Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Updates #568

Closed
wants to merge 17 commits into from
Closed

CI Updates #568

wants to merge 17 commits into from

Conversation

pyrox0
Copy link
Contributor

@pyrox0 pyrox0 commented Mar 25, 2024

This PR does 2 things:

  • A pr-manager action that checks FCP dates, notifies the mappings team if a PR is done in FCP, and also ensures all needed labels are assigned to a PR.
  • Updates the javascript dependencies of the update-base and diff-uploader actions. This also solves some warnings that appear under running those actions.

ix0rai
ix0rai reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more !!remindme !

@ix0rai ix0rai added enhancement new feature or request t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft labels Mar 25, 2024
ix0rai
ix0rai approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a web dev but this looks fantastic!

IotaBread
IotaBread reviewed Mar 27, 2024
View reviewed changes
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Mar 27, 2024
@github-actions github-actions bot changed the base branch from 24w12a to 24w13a March 27, 2024 17:13
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 24w13a

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Mar 27, 2024
@ix0rai ix0rai added the final-comment-period is approved and will soon be merged if no issues are raised label Mar 31, 2024
@pyrox0 pyrox0 removed the final-comment-period is approved and will soon be merged if no issues are raised label Apr 1, 2024
@pyrox0
Copy link
Contributor Author

pyrox0 commented Apr 1, 2024

Taking this out of FCP since there's some improvements I need to make to it.

@IotaBread IotaBread changed the base branch from 24w13a to 24w14a April 10, 2024 01:22
@OroArmor OroArmor added the update-base used to notify github actions that the base branch should be updated label Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 1.20.5-rc2

@github-actions github-actions bot changed the base branch from 24w14a to 1.20.5-rc2 April 19, 2024 20:03
@pyrox0 pyrox0 removed the update-base used to notify github actions that the base branch should be updated label Apr 19, 2024
OroArmor
OroArmor requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a lot of the information is within the log and not a comment. Having a comment or something would be much nicer.

Also I could have missed it, but is there a way to cancel an FCP

@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 1.20.5-rc3

@github-actions github-actions bot changed the base branch from 1.20.5-rc2 to 1.20.5-rc3 April 22, 2024 20:25
@github-actions github-actions bot changed the base branch from 24w21a to 1.21-pre1 May 30, 2024 03:28
@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label May 30, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Jun 4, 2024
@github-actions github-actions bot changed the base branch from 1.21-pre1 to 1.21-pre2 June 4, 2024 22:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

🚀 Target branch has been updated to 1.21-pre2

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Jun 4, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Jun 6, 2024
@github-actions github-actions bot changed the base branch from 1.21-pre2 to 1.21-pre3 June 6, 2024 19:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

🚀 Target branch has been updated to 1.21-pre3

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Jun 6, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Jun 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

🚀 Target branch has been updated to 1.21-pre4

@github-actions github-actions bot changed the base branch from 1.21-pre3 to 1.21-pre4 June 9, 2024 03:22
@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Jun 9, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 1.21-rc1

@github-actions github-actions bot changed the base branch from 1.21-pre4 to 1.21-rc1 June 11, 2024 01:13
@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Jun 11, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Target branch has been updated to 1.21

@github-actions github-actions bot changed the base branch from 1.21-rc1 to 1.21 June 14, 2024 00:12
@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Jun 14, 2024
@pyrox0
Copy link
Contributor Author

pyrox0 commented Jun 27, 2024

Closing per what I said in the quilt mappings discord thread, someone else can pick this up if they want.

@pyrox0 pyrox0 closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IotaBread IotaBread IotaBread left review comments

@OroArmor OroArmor OroArmor requested changes

@ix0rai ix0rai ix0rai approved these changes

@moehreag moehreag moehreag approved these changes

Assignees
No one assigned
Labels
enhancement new feature or request t: toolchain changes to the quilt mappings toolchain v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pyrox0 @OroArmor @IotaBread @ix0rai @moehreag