Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt avoid timestamp #96

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Opt avoid timestamp #96

merged 3 commits into from
Nov 19, 2024

Conversation

RCasatta
Copy link
Owner

No description provided.

Before this commit is not possible to publish because the docs build
fails.
The Readme is not reachable from the because in the workspace
directory, this add a soft link to the upper directory and remove one
level in the path.
link the upper readme for the cli, going forward cli and lib should have
separate readmes
useful when running in systemd to avoid duplicate times avoiding
precious terminal space
@RCasatta RCasatta merged commit 7b41941 into master Nov 19, 2024
10 checks passed
@dpc
Copy link
Contributor

dpc commented Nov 19, 2024

@RCasatta BTW. If you're using env_logger, you should be aware of rust-cli/env_logger#123 , maybe you want to disable regex cargo feature on it.

@RCasatta
Copy link
Owner Author

oh didn't know... Thanks for the info

@RCasatta
Copy link
Owner Author

I don't see log in perf reports of a another project of mine. I disabled regex feature of env_logger and didn't notice perf difference before/after

image

@dpc
Copy link
Contributor

dpc commented Nov 20, 2024

Did you set the RUST_LOG to anything? It kicks in only after it's actually filtering. Also - if you don't happen to have any heavy traces etc in hot loops in your deps, it might actually not be a problem.

@RCasatta
Copy link
Owner Author

RUST_LOG is unset, but internally I have
let mut builder = env_logger::Builder::from_env(Env::default().default_filter_or("info"));

So I supposed it could have been affected, but it seems not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants