Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RCP-51] DOM Increment #157

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryanburgers
Copy link

@bryanburgers bryanburgers commented Dec 23, 2024

Rendered

A couple of notes.

Field naming

I evaluated the following three sets of names.

  • DaysOnMarketReplicationYN/DaysOnMarketReplication/DaysOnMarketReplicationTimestamp/.../CumulativeDaysOnMarketReplicationTimestamp
    • Pro: close to what CoreLogic uses. (Except they use DaysOnMarketReplicationDate, but it was decided in meeting that the group prefers to use timestamps.)
    • Con: this isn't just about replication.
    • Con: CumulativeDaysOnMarketReplicationTimestamp is 42 characters, which would make it the longest name in the Data Dictionary
      Media's OriginatingSystemResourceRecordSystemId is 39
      Property's longest is InternetAutomatedValuationDisplayYN at 35.
  • DaysOnMarketIncrementYN/DaysOnMarketIncrementBase/DaysOnMarketIncrementTimestamp/.../CumulativeDaysOnMarketIncrementTimestamp
  • DomIncrementYN/DomIncrementBase/DomIncrementTimestamp/.../CdomIncrementTimestamp
    • Pro: uses the name of the feature that Paul coined directly in the name
    • Pro: not overly long for 3 to 6 fields that might show up on every property record
    • Con: abbreviation for DaysOnMarket and CumulativeDaysOnMarket used

I settled on the last set, but I'm certainly open to bikeshedding.

After discussion, option 2 was chosen because spelling out "DaysOnMarket" is more consistent with what is currently in the Data Dictionary.

Testing

Looking through the DD tests, I found a bunch of checks on metadata.

I'm wondering if this spec needs tests at the per-record level, and if so I didn't see how to do that. So I just explained the tests I wanted to see.

Additional material

At this point, there is a bunch of written material in a variety of locations – the closed discussion, some gists that were linked to from the discussion, etc.

I hope to bring that all together into an explainer at some point. I'm not blocking this proposal on the explainer because an explainer doesn't belong in the proposal anyway.

Collaboration

I definitely consider this a first draft. I'm willing to work with anyone who wants to improve it. On the issue it looked like @SergioDelRioT4Bi might be willing to help, for one?

Issue #150

@bryanburgers bryanburgers changed the title RCP 51: DOM Increment [RCP 51] DOM Increment Jan 6, 2025
@bryanburgers bryanburgers changed the title [RCP 51] DOM Increment [RCP-51] DOM Increment Jan 6, 2025
@darnjo darnjo modified the milestones: Data Dictionary 2.1, Backlog Jan 10, 2025
@darnjo
Copy link
Member

darnjo commented Jan 15, 2025

I hope to bring that all together into an explainer at some point. I'm not blocking this proposal on the explainer because an explainer doesn't belong in the proposal anyway.

Everything relevant to the spec should be in the specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants