Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
A couple of notes.
Field naming
I evaluated the following three sets of names.
DaysOnMarketReplicationYN
/DaysOnMarketReplication
/DaysOnMarketReplicationTimestamp
/.../CumulativeDaysOnMarketReplicationTimestamp
DaysOnMarketReplicationDate
, but it was decided in meeting that the group prefers to use timestamps.)CumulativeDaysOnMarketReplicationTimestamp
is 42 characters, which would make it the longest name in the Data DictionaryMedia's OriginatingSystemResourceRecordSystemId is 39
Property's longest is InternetAutomatedValuationDisplayYN at 35.
DaysOnMarketIncrementYN
/DaysOnMarketIncrementBase
/DaysOnMarketIncrementTimestamp
/.../CumulativeDaysOnMarketIncrementTimestamp
CumulativeDaysOnMarketIncrementTimestamp
is 40 characters, which would make it the longest name in the Data DictionaryOriginatingSystemResourceRecordSystemId
is 39InternetAutomatedValuationDisplayYN
at 35.DomIncrementYN
/DomIncrementBase
/DomIncrementTimestamp
/.../CdomIncrementTimestamp
I settled on the last set, but I'm certainly open to bikeshedding.After discussion, option 2 was chosen because spelling out "DaysOnMarket" is more consistent with what is currently in the Data Dictionary.
Testing
Looking through the DD tests, I found a bunch of checks on metadata.
I'm wondering if this spec needs tests at the per-record level, and if so I didn't see how to do that. So I just explained the tests I wanted to see.
Additional material
At this point, there is a bunch of written material in a variety of locations – the closed discussion, some gists that were linked to from the discussion, etc.
I hope to bring that all together into an explainer at some point. I'm not blocking this proposal on the explainer because an explainer doesn't belong in the proposal anyway.
Collaboration
I definitely consider this a first draft. I'm willing to work with anyone who wants to improve it. On the issue it looked like @SergioDelRioT4Bi might be willing to help, for one?
Issue #150