fix(HMS-3185): fail with 403 on failed assume role #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
force-pushed
the
assume_role_forbidden
branch
2 times, most recently
from
c130e54
to
f1e53f7
Compare
lzap
requested changes
Nov 29, 2023
ezr-ondrej
force-pushed
the
assume_role_forbidden
branch
from
f1e53f7
to
e3f2a27
Compare
|
/retest |
1 similar comment
|
/retest |
ezr-ondrej
force-pushed
the
assume_role_forbidden
branch
from
e3f2a27
to
2fdf214
Compare
AssumeRole is supposed to assume the role that client is giving us. This fixes the error code when this operation fails. It could have also been 401 as the role might be considered an input. Given this is a permissions operation, we went with 403.
ezr-ondrej
force-pushed
the
assume_role_forbidden
branch
from
2fdf214
to
c40e20d
Compare
lzap
approved these changes
Nov 30, 2023
|
/retest |
|
We are 🍏 lets get it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssumeRole is supposed to assume the role that client is giving us. This fixes the error code when this operation fails.
It could have also been 401 as the role might be considered an input. Given this is a permissions operation, I went with 403.
Let me know if you think 401 (or any other code) would be more fitting.
I've went bit overboard to mimic the error that AWS returns in our stub.
But now it should test the real thing pretty closely.