fix(HMS-1847): Removing location and resource group #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurilahane
changed the title
mayurilahane
force-pushed
the
mlahane/removing_location_and_resource_group
branch
from
62326ba
to
eb5bf86
Compare
|
The commit message is missing space after |
|
@mshriver needs ack here |
mayurilahane
force-pushed
the
mlahane/removing_location_and_resource_group
branch
from
eb5bf86
to
029616a
Compare
mshriver
approved these changes
Nov 28, 2023
|
/retest |
akhil-jha
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added a new vault path for only secrets.
https://vault.devshift.net/ui/vault/secrets/insights/show/secrets/qe/global/hms/azure
and removed the location and resource group field of auth from the previous path.
now pod spec will fetch the location and resource group value from the configmap file instead of overriding it from the secrets file.