refactor: upgrade to identity v2 #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait it is green on CI, only on my local system. Damn and I spent hours debugging. |
|
Well, that would have been too eays, huh? Not sure what is wrong atm. |
|
My theory is that the HTTP RH identity header is not getting passed in correctly into RBAC, added a log statement to see it. |
|
/retest |
|
I guess we need to bump the version manually, right? |
Signed-off-by: Lukas Zapletal <[email protected]>
ezr-ondrej
approved these changes
Jan 25, 2024
|
Holy crap that was it! Cool. |
|
Yeah let’s go for it rather now so we have Friday to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA
I am not able to clean out test failure, giving up for today I guess.