Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure default DNS resolver in 6lbr example #21117

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Configure default DNS resolver in 6lbr example #21117

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e668ac4
examples/gnrc_border_router: set DNS resolver
OlegHahm Jan 2, 2025
115b8d9
examples/gnrc_border_router: add DNS option
OlegHahm Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/gnrc_border_router/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ USEMODULE += ps
# Optionally include DNS support. This includes resolution of names at an
# upstream DNS server and the handling of RDNSS options in Router Advertisements
# to auto-configure that upstream DNS server.
#USEMODULE += sock_dns # include DNS client
#USEMODULE += gnrc_ipv6_nib_dns # include RDNSS option handling
USEMODULE += sock_dns # include DNS client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
USEMODULE += sock_dns # include DNS client
USEMODULE += dns_cache # cache DNS responses
USEMODULE += sock_dns # include DNS client

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think here too some ENABLE_DNS ?= 1 switch or something of the like would be helpful, in case e.g. you don't want the border router include RDNSS options in its RAs (e.g. to prevent RA fragmentation).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to address both comments in my latest commit.

USEMODULE += gnrc_ipv6_nib_dns # include RDNSS option handling
USEMODULE += auto_init_sock_dns # configure default DNS resolver

# When using a regular network uplink we should use DHCPv6
ifneq (,$(filter cdc-ecm wifi ethernet,$(UPLINK))$(REUSE_TAP))
Expand Down
Loading