-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: basic periph timer #31
Conversation
@MichelRottleuthner as discussed f2f these are my refinements of your initial PR which you can use as starting point to work on more complex timer tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and it passes on the nucleo-l433rc. Generally I think this is OK assuming it is part of an iteration.
cefa32e
to
fc69163
Compare
This one should be ready to go. Please note only the new boards support all features, i.e. the debug pins - so failing tests are expected. Alternative would be to remove the tests that require debug pins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested it again locally and it works as expected also on my nucleo-l476rg.
Two things as a sidenote:
you know whats going on with the nucleo-f767zi (HIL reports timeouts..)?
Why is the extension *.txt used for keyword definition files instead of *.robot? This way we don't get syntax highlighting on Github . For robot both should be fine, no?
Regarding your point on "failing tests are expected" I'm for leaving in the debug-pin related things so we have a strong motivation to properly connect up all the boards soon ;)
This PR is a refined and stripped down version of #30, i.e. adapting tests scripts and firmware to adhere with the structure and concept of existing tests.