Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: basic periph timer #31

Merged
merged 6 commits into from
Oct 15, 2019
Merged

tests: basic periph timer #31

merged 6 commits into from
Oct 15, 2019

Conversation

smlng
Copy link
Member

@smlng smlng commented Sep 26, 2019

This PR is a refined and stripped down version of #30, i.e. adapting tests scripts and firmware to adhere with the structure and concept of existing tests.

@smlng smlng added the enhancement New feature or request label Sep 26, 2019
@smlng
Copy link
Member Author

smlng commented Sep 26, 2019

@MichelRottleuthner as discussed f2f these are my refinements of your initial PR which you can use as starting point to work on more complex timer tests.

Copy link
Collaborator

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it passes on the nucleo-l433rc. Generally I think this is OK assuming it is part of an iteration.

tests/periph_timer/tests/periph_timer.keywords.txt Outdated Show resolved Hide resolved
tests/periph_timer/tests/periph_timer_if.py Show resolved Hide resolved
@smlng smlng force-pushed the pr_timer_basic branch 3 times, most recently from cefa32e to fc69163 Compare October 10, 2019 18:53
@smlng
Copy link
Member Author

smlng commented Oct 11, 2019

This one should be ready to go. Please note only the new boards support all features, i.e. the debug pins - so failing tests are expected. Alternative would be to remove the tests that require debug pins.

Copy link
Contributor

@MichelRottleuthner MichelRottleuthner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it again locally and it works as expected also on my nucleo-l476rg.
Two things as a sidenote:
you know whats going on with the nucleo-f767zi (HIL reports timeouts..)?
Why is the extension *.txt used for keyword definition files instead of *.robot? This way we don't get syntax highlighting on Github . For robot both should be fine, no?
Regarding your point on "failing tests are expected" I'm for leaving in the debug-pin related things so we have a strong motivation to properly connect up all the boards soon ;)

@MrKevinWeiss MrKevinWeiss merged commit 442b2da into master Oct 15, 2019
@MrKevinWeiss MrKevinWeiss deleted the pr_timer_basic branch November 13, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants