Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update setup.py #172

wants to merge 1 commit into from

Conversation

jazzpher
Copy link

  • Add comments to explain various sections and functions.
  • Check Python version compatibility using six for a more concise and maintainable approach.
  • Utilize triple-quoted strings for docstrings to enhance documentation.
  • Employ f-strings for improved string formatting.
  • Use the with statement for file handling, ensuring files are properly closed.
  • Improve error handling by using subprocess.run to capture results and check for errors.
  • Utilize a list comprehension for the keywords list, making it more concise.
  • Specify the required Python version in the setup script using python_requires.

- Add comments to explain various sections and functions.
- Check Python version compatibility using six for a more concise and maintainable approach.
- Utilize triple-quoted strings for docstrings to enhance documentation.
- Employ f-strings for improved string formatting.
- Use the with statement for file handling, ensuring files are properly closed.
- Improve error handling by using subprocess.run to capture results and check for errors.
- Utilize a list comprehension for the keywords list, making it more concise.
- Specify the required Python version in the setup script using python_requires.
@stonebig
Copy link

stonebig commented Dec 9, 2023

it would have been nice to merge this, so pyflux can install on Python-3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants