Replacing vector with InlineVector in TensorDescriptor #3502
+998
−565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novakovicdj
requested review from
BrianHarrisonAMD and
BradPepersAMD
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is replacing
std::vectorwithInlineVectorinTensorDescriptorfor lens/strides.InlineVector#3419I did some performance testing to compare
InlineVectorwithstd::vector(initialization, elements access etc). The results are thatInlineVectoris ~6% faster thanstd::vector. For example initialization with 5 elements forInlineVectortakes around 20.25ns, and initialization with 5 elements forstd::vectortakes around 21.85ns.Based on these results I made changes in the code. I tried to make only necessary changes and to reduce overhead as much as possible (especially in the
src/), also some changes needed to be made inInlineVectoritself to be able to complete this change.