Use a GitHub app for syncing rocm-main and upstream main #224
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleshofer
requested review from
mrodden,
JehandadKhan,
Ruturaj4 and
zahiqbal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the nightly sync job fails if upstream makes changes to some of its CI workflows, even for workflow files that we don't use. Workflow files change probably every other day, so this means that I spend some time every other day having to babysit the sync job.
The default GitHub runner account disallows making changes to workflow files for security reasons. However, you can change workflow files if you run the workflow using a GitHub App instead of the default runner account. Divin created an app for us that should have all the right permissions. I've added the ID and key for it to this repo, and this PR adds a step that will generate a token that Actions can use to authenticate to the GitHub API as the app.