Don't let a swap off fail cause teardown failure

RSE-Cambridge · Jan 7, 2019 · 3af7c86 · 3af7c86
1 parent 45246e7
commit 3af7c86
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/pkg/pfsprovider/ansible/mount.go b/internal/pkg/pfsprovider/ansible/mount.go
@@ -133,10 +133,10 @@ func umount(fsType FSType, volume registry.Volume, brickAllocations []registry.B
 			swapFile := path.Join(mountDir, fmt.Sprintf("/swap/%s", attachment.Hostname)) // TODO share?
 			loopback := fmt.Sprintf("/dev/loop%d", volume.ClientPort)                     // TODO share?
 			if err := swapOff(attachment.Hostname, loopback); err != nil {
-				return err
+				log.Printf("Warn: failed to swap off %+v", attachment)
 			}
 			if err := detachLoopback(attachment.Hostname, loopback); err != nil {
-				return err
+				log.Printf("Warn: failed to detach loopback %+v", attachment)
 			}
 			if err := removeSubtree(attachment.Hostname, swapFile); err != nil {
 				return err