Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for S4S Imaging Demo #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

abjonnes
Copy link

@abjonnes abjonnes commented Nov 27, 2018

We (Sync for Science) are developing a demo application of the imaging stack which runs in the browser. Part of the demo is fetching the FHIR ImageStudy data from the FHIR broker, which fails due to a Access-Control-Request-Headers: Authorization header in the pre-flight request from the browser. Adding Authorization to the allowed headers list in the CORS configuration allows the request to succeed.

See also a similar pull request in the DICOM-RS broker repository.

@abjonnes abjonnes changed the title Add Authorization to the list of allowed CORS headers Bug fixes for S4S Imaging Demo Nov 29, 2018
@abjonnes
Copy link
Author

I added a few more commits to cover some other bugs we encountered. We want to use the forwarding capability in this project to forward the DICOM data from the DICOM-RS broker to the client but there were some issues:

  • The headers were not being forwarded correctly (see the Java docs - the 0th header was the HTTP status line so the value of conn.getHeaderFieldKey(0) was null even though there were other headers)
  • The DICOM-RS broker returns a 503 error when the data isn't ready, but this wasn't being handled well (an empty 200 response was being returned to the client)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant