Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Lambda functions instead of functor classes in JosephForwardProjectionFilter #694

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ENH: Lambda functions instead of functor classes in JosephForwardProjectionFilter #694

wants to merge 2 commits into from

Conversation

MichaelColonel
Copy link

Implementation of lambdas instead of functor classes in rtkJosephForwardProjectionFilter.
Test example of MIP filter using this new class.

Possible solution of issue #645.

@SimonRit
Copy link
Collaborator

Thanks a lot for doing this. Could you please modify the existing projector instead of creating a new one? That would facilitate the review and this is what we want eventually.
This is a big change so it will take time before we all agree on this...

@MichaelColonel
Copy link
Author

Could you please modify the existing projector instead of creating a new one? That would facilitate the review and this is what we want eventually.

I will do that, but what to do with JosephForwardAttenuatedProjectionImageFilter class?
There are some private members within functors classes, which can't be implemented in lambda functions.

@MichaelColonel
Copy link
Author

I've modified existing classes for JosephForwardProjectionFilter.
Not so sure about JosephForwardAttenuatedProjectionImageFilter though, in any case this PR is ready for a review.

@MichaelColonel MichaelColonel changed the title WIP: lambdas instead of functors in rtkJosephForwardProjectionFilter ENH: Lambda functions instead of functor classes in JosephForwardProjectionFilter Mar 4, 2025
ENH: Use lambda functions instead of functor classes in rtkJosephForw…
de18d67 
…ardProjectionFilter

Lambdas were added to the classes:
  JosephForwardProjectionImageFilter,
  JosephForwardAttenuatedProjectionImageFilter,
  MaximumIntensityProjectionImageFilter.

Python wrappers for classes above have been modified.

Similar lambda functions can be added to back projection classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelColonel @SimonRit