Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard to prevent onDestroy being called after component has been removed #528

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

tkshnwesper
Copy link
Contributor

@tkshnwesper tkshnwesper commented Jun 11, 2024

Description

  • Add guard in FlyingAttackGameObject to prevent calling onDestroy after component has been destroyed.
  • Refactor: remove redundant parameters

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I open this PR to the develop branch.
  • I have added a description of the change under [next] in CHANGELOG.md.
  • I ran dart format --output=none --set-exit-if-changed . and has success.

Breaking Change

Does your PR require Flame users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md).
  • No, this is not a breaking change.

@RafaelBarbosatec
Copy link
Owner

LGTM! Thanks so much for contributing!

@RafaelBarbosatec RafaelBarbosatec merged commit d04df16 into RafaelBarbosatec:develop Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants