-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Music" from Clapper's keywords to lower its priority as a music player #525
base: master
Are you sure you want to change the base?
Conversation
…ic player This PR removes the keyword "Music" from Clapper's `.desktop` file to lower its priority as a music player in desktop search results. This ensures that Clapper is not prominently suggested when searching for music-related applications, while retaining its functionality as a video player. ### Changes: - Removed "Music" from the `Keywords` field in the `.desktop` file. This change does not affect Clapper's ability to play audio files but adjusts its visibility in application search results.
If we are doing cleanup there, we might as well remove all other similarly unneeded entries. I think we might want to remove
Anything else? |
keep in mind that it will have to removed from the translations as well |
Yes, that's why its better to do this once and good then translate. Also, this is a reason why this change will be |
I'm not so sure. Right now most translations do not have translated desktop categories yet, better to remove them sooner than later before the other translators get to it. |
Once PR is finished, I can merge it and update POT files, so newly done translations can be from updated string already. What I am not sure, is whether to backport it into 0.8 later on. I guess this will depend if all already done translations will update accordingly. We do not want to do a patch version where there is less translated then before. |
I have updated the PR to remove all the suggested keywords (Album, GNOME, Clapper) along with Music from the desktop file. Let me know if any other changes are needed ^^ |
Thanks for update. Keywords look fine to me, but if anyone else has ideas what to add/remove there, suggestions are welcome. The remaining questions after this change, are:
My guess is to maybe update comment and leave mime types as they are? 🤔 |
Yeah, I think keeping the MimeTypes and Comment as they are makes sense - users can still play audio if they want to, and with the planned features like cover art and CD support, having audio support mentioned in the description still fits. The keyword changes should help with the search results without limiting any functionality. |
OK. This seems fine and nobody is suggesting any changes anymore. Thanks! I will merge this over weekend, since I still have some post-release repo updates to do first. NOTE TO SELF: Bump to |
This PR removes several keywords from Clapper's
.desktop
file to improve search result relevance:Changes:
These changes adjust Clapper's visibility in application search results while maintaining all functionality.