Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Music" from Clapper's keywords to lower its priority as a music player #525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abhijeeth-babu
Copy link

@abhijeeth-babu abhijeeth-babu commented Jan 25, 2025

This PR removes several keywords from Clapper's .desktop file to improve search result relevance:

Changes:

  • Removed "Album" - redundant for video player
  • Removed "GNOME" - not a GNOME-specific app
  • Removed "Clapper" - already in app name/desktop file
  • Removed "Music" - lower priority as music player

These changes adjust Clapper's visibility in application search results while maintaining all functionality.

…ic player

This PR removes the keyword "Music" from Clapper's `.desktop` file to lower its priority as a music player in desktop search results. This ensures that Clapper is not prominently suggested when searching for music-related applications, while retaining its functionality as a video player.

### Changes:
- Removed "Music" from the `Keywords` field in the `.desktop` file.

This change does not affect Clapper's ability to play audio files but adjusts its visibility in application search results.
@Rafostar
Copy link
Owner

Rafostar commented Jan 27, 2025

If we are doing cleanup there, we might as well remove all other similarly unneeded entries.

I think we might want to remove Album;GNOME;Clapper too, for reasons:

  • Album - probably the same issue as "Music"
  • GNOME - this is not a GNOME only app (and neither it is an core/circle one)
  • Clapper - probably not needed since desktop file/app name is the same

Anything else?

@sp1ritCS
Copy link
Contributor

keep in mind that it will have to removed from the translations as well

@Rafostar
Copy link
Owner

keep in mind that it will have to removed from the translations as well

Yes, that's why its better to do this once and good then translate. Also, this is a reason why this change will be 0.10 version material.

@sp1ritCS
Copy link
Contributor

Also, this is a reason why this change will be 0.10 version material

I'm not so sure. Right now most translations do not have translated desktop categories yet, better to remove them sooner than later before the other translators get to it.

@Rafostar
Copy link
Owner

Rafostar commented Jan 27, 2025

better to remove them sooner than later before the other translators get to it.

Once PR is finished, I can merge it and update POT files, so newly done translations can be from updated string already. What I am not sure, is whether to backport it into 0.8 later on. I guess this will depend if all already done translations will update accordingly. We do not want to do a patch version where there is less translated then before.

@abhijeeth-babu
Copy link
Author

I have updated the PR to remove all the suggested keywords (Album, GNOME, Clapper) along with Music from the desktop file. Let me know if any other changes are needed ^^

@Rafostar
Copy link
Owner

Rafostar commented Jan 28, 2025

Thanks for update. Keywords look fine to me, but if anyone else has ideas what to add/remove there, suggestions are welcome.

The remaining questions after this change, are:

  • If we no longer advertise as Music, should app "Comment" be updated?
  • What about supported MimeTypes?

My guess is to maybe update comment and leave mime types as they are? 🤔
This way we won't advertise as music player (since we focus on videos), but still allow to set Clapper as default file handler?

@Rafostar
Copy link
Owner

Rafostar commented Jan 28, 2025

Or maybe just leave "Comment" as-is, since we technically can play them and there are requests for cover art (#64), reading CDs (#216), etc.

@abhijeeth-babu
Copy link
Author

Yeah, I think keeping the MimeTypes and Comment as they are makes sense - users can still play audio if they want to, and with the planned features like cover art and CD support, having audio support mentioned in the description still fits. The keyword changes should help with the search results without limiting any functionality.
Let me know if you want me to change anything else in the PR!

@Rafostar
Copy link
Owner

Rafostar commented Jan 31, 2025

OK. This seems fine and nobody is suggesting any changes anymore. Thanks!

I will merge this over weekend, since I still have some post-release repo updates to do first.

NOTE TO SELF: Bump to 0.9.0 before merging!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants