Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Season of Discovery Runes #104

Merged
merged 26 commits into from
Jan 11, 2025
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c512a80
Fix logging in itemManager find item function
RagedUnicorn Jul 5, 2024
809fe77
Add sod rune implementation for gearBar
RagedUnicorn Jul 6, 2024
c18068a
Fix rune startup loading
RagedUnicorn Jul 6, 2024
54b1e8c
Fix updating runeslots when adding/removing gearbar slot
RagedUnicorn Jul 7, 2024
35eee2f
Fix addon startup load inventory
RagedUnicorn Jul 7, 2024
6459bd5
Guard loading of runes with season clause
RagedUnicorn Jul 7, 2024
9c561bc
Implement runes for changemenu
RagedUnicorn Jul 7, 2024
e7ee0d5
Remove enchantId param from UpdateCombatQueue
RagedUnicorn Jul 7, 2024
93210ca
Improve logging for FindItemInBag
RagedUnicorn Jul 7, 2024
6a4d24f
Fix luacheck warnings
RagedUnicorn Jul 9, 2024
9891c1a
Increase keybind update delay
RagedUnicorn Jul 10, 2024
4d165bb
Hide rune on emptyslot
RagedUnicorn Jul 11, 2024
3bfec6f
Increase keybind delay to 1 second
RagedUnicorn Jul 11, 2024
23b43c9
Add base implementation rune support for quickchange
RagedUnicorn Jul 11, 2024
2e396c4
Fix macrobridge to work with runes
RagedUnicorn Jul 11, 2024
feb109f
When searching items in bag an enchantid is nil ignore it
RagedUnicorn Jul 27, 2024
62b0628
Cleanup engraving implementation
RagedUnicorn Oct 12, 2024
1da5d58
Fixes #102 - Do not access ui elements if they are not built
RagedUnicorn Dec 27, 2024
3038e2b
Add rune support for quickChange rules
RagedUnicorn Jan 8, 2025
1d7a3e5
Improve loading of keybinds on startup
RagedUnicorn Jan 8, 2025
f5e9b66
Add safety checks for retrieving cooldowns #103
RagedUnicorn Jan 8, 2025
e9b213d
Disable Rune configuration menu if sod is not active
RagedUnicorn Jan 9, 2025
863993e
Add SOD Rune documentation
RagedUnicorn Jan 11, 2025
e07350c
Update gearmenu version to 2.4.0
RagedUnicorn Jan 11, 2025
626a85a
Update release notes for 2.4.0
RagedUnicorn Jan 11, 2025
65ab311
Update licensing year to 2025
RagedUnicorn Jan 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove enchantId param from UpdateCombatQueue
* Only the icon is necessary to update the visual representation
RagedUnicorn committed Jan 8, 2025

Verified

This commit was signed with the committer’s verified signature. The key has expired.
robstoll Robert Stoll
commit e7ee0d577c8e3e3e9a52f363a97e05c489529fb0
4 changes: 2 additions & 2 deletions code/GM_CombatQueue.lua
Original file line number Diff line number Diff line change
@@ -79,7 +79,7 @@ function me.AddToQueue(itemId, enchantId, runeAbilityId, slotId)
mod.logger.LogDebug(me.tag, "Added item with itemId " .. itemId .. " and enchantId " .. (enchantId or "nil") ..
" in slotId " .. slotId .. " to combatQueueStore")

mod.gearBar.UpdateCombatQueue(itemId, enchantId, slotId)
mod.gearBar.UpdateCombatQueue(itemId, slotId)
mod.ticker.StartTickerCombatQueue()
end

@@ -107,7 +107,7 @@ function me.RemoveFromQueue(slotId)
combatQueueStore[slotId] = nil
mod.logger.LogDebug(me.tag, "Removed item with id " .. itemId .. " in slotId "
.. slotId .. " from combatQueueStore")
mod.gearBar.UpdateCombatQueue(nil, nil, slotId)
mod.gearBar.UpdateCombatQueue(nil, slotId)
end

--[[
5 changes: 2 additions & 3 deletions gui/GM_GearBar.lua
Original file line number Diff line number Diff line change
@@ -321,11 +321,10 @@ end

@param {number} itemId
The itemId to update the combatQueue for
@param {number} enchantId
@param {number} slotId
The slotId to update the combatQueue for
]]--
function me.UpdateCombatQueue(itemId, enchantId, slotId)
function me.UpdateCombatQueue(itemId, slotId)
mod.logger.LogDebug(me.tag, "Updating combatqueues for slotId - " .. slotId)

for _, gearBar in pairs(mod.gearBarStorage.GetGearBars()) do
@@ -336,7 +335,7 @@ function me.UpdateCombatQueue(itemId, enchantId, slotId)
local icon = gearSlots[i].combatQueueSlot.icon

if itemId then
local bagNumber, bagPos = mod.itemManager.FindItemInBag(itemId, enchantId)
local bagNumber, bagPos = mod.itemManager.FindItemInBag(itemId)

if bagNumber ~= nil and bagPos ~= nil then
local itemInfo = C_Container.GetContainerItemInfo(bagNumber, bagPos)