Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite prescaler enum in ATtiny xmega SPI*.CTRLA #172

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

innermatrix
Copy link
Contributor

This uses the same convention as SPI FOSC* in patch/common/spi.yaml

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you have more changes of this kind planned or do you consider the ATtiny XMEGA support ready for release now? Just want to make sure I don't release a new version of avr-device just to then pull more breaking changes for one of the new MCUs :)

@Rahix Rahix merged commit 783e731 into Rahix:main Jan 4, 2025
2 checks passed
@innermatrix
Copy link
Contributor Author

innermatrix commented Jan 4, 2025

Thanks! Do you have more changes of this kind planned or do you consider the ATtiny XMEGA support ready for release now? Just want to make sure I don't release a new version of avr-device just to then pull more breaking changes for one of the new MCUs :)

On the one hand I don't have any further changes (breaking or non-breaking) sitting in my WIP PRs.

On the other hand, avr-hal-generic has limited support for xmega peripherals, so I am incrementally building that out in my fork of avr-hal and it's not out of the question that as I build that out I might discover more changes are needed in avi-device. Thus far I got I2C host, SPI host, and USART support in avr-hal-generic to compile against these changes in avr-device, so I am moderately confident about those, but I haven't touched PWM, ADC, or EEPROM yet, so those I am less confident about.

Tell me your thoughts? If you'd prefer to keep these devices out until I feel more confident, I am fine with that.

@Rahix
Copy link
Owner

Rahix commented Jan 4, 2025

If changes become necessary, we'll do them as they arise. Just wanted to know if you are sitting on any more known pending issues. But if not, then I'll be optimistic and cut a new release soon :)

@innermatrix
Copy link
Contributor Author

Nope, you're fully caught up on my WIP now 🙂 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants