Prevent nil error which occures sometimes at end of M+ run #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…String which is where it appears to live
- Made the replay timer count up and include the death penalty when a replay is running - Made the ahead/behind colors show, so it only colorizes when there is a difference > 0 - Show the replay frame when in Mythic dungeons, because this will be when people will probably want to choose which replay to run against. - Hide "your side" of the comparison when not in an active replay - Reduced font size - Always showing Boss count
added hover tooltip to the replay frame that shows the title of the replay you are going against added in-combat indicator on the main section of the replay frame
trash only matters if it gets to 100%, so make sure that we do not show as being behind if live = 100 and replay > 100
…stments Feature/patch 10 2 adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
796x RaiderIO/core.lua:7943: attempt to perform arithmetic on field 'killed' (a nil value)
[string "@RaiderIO/core.lua"]:7943: in function
Update' [string "@RaiderIO/core.lua"]:7927: in functionSetup'[string "@RaiderIO/core.lua"]:9922: in function
SetUIBosses' [string "@RaiderIO/core.lua"]:9616: in functionOnBossKill'[string "@RaiderIO/core.lua"]:8486: in function
GetSummary' [string "@RaiderIO/core.lua"]:9671: in functionUpdateShown'[string "@RaiderIO/core.lua"]:10199: in function
callbackFunc' [string "@RaiderIO/core.lua"]:1126: in functionSendEvent'[string "@RaiderIO/core.lua"]:1061: in function <RaiderIO/core.lua:1057>
Locals:
Skipped (In Encounter)
prevent the nil error by verifying the value exists.